Fixed QDnsRecordData clone() method and tests

src/modules/dns-base/CMakeLists.txt

@@ -30,7 +30,13 @@ add_library(${PROJECT_NAME}
         src/RecordData/QDnsRecordDataRaw.cpp
         includes/dns-base/RecordData/QDnsRecordDataRaw.h
         src/RecordData/QDnsRecordDataAAAA.cpp
-        includes/dns-base/RecordData/QDnsRecordDataAAAA.h src/RecordData/QDnsRecordDataMX.cpp includes/dns-base/RecordData/QDnsRecordDataMX.h src/RecordData/QDnsRecordDataSOA.cpp includes/dns-base/RecordData/QDnsRecordDataSOA.h src/RecordData/QDnsRecordDataPTR.cpp includes/dns-base/RecordData/QDnsRecordDataPTR.h)
+        includes/dns-base/RecordData/QDnsRecordDataAAAA.h
+        src/RecordData/QDnsRecordDataMX.cpp
+        includes/dns-base/RecordData/QDnsRecordDataMX.h
+        src/RecordData/QDnsRecordDataSOA.cpp
+        includes/dns-base/RecordData/QDnsRecordDataSOA.h
+        src/RecordData/QDnsRecordDataPTR.cpp
+        includes/dns-base/RecordData/QDnsRecordDataPTR.h)
 
 target_link_libraries(${PROJECT_NAME} Qt5::Core Qt5::Network)
 

src/modules/dns-base/src/RecordData/QDnsRecordDataA.cpp

@@ -59,7 +59,7 @@ namespace QDns
             auto data = new QDnsRecordDataA();
             data->m_isValid = m_isValid;
             data->m_ip = m_ip;
-            return nullptr;
+            return data;
         }
 
         const QHostAddress &QDnsRecordDataA::getIp() const

src/modules/dns-base/src/RecordData/QDnsRecordDataAAAA.cpp

@@ -68,7 +68,7 @@ namespace QDns
             auto data = new QDnsRecordDataAAAA();
             data->m_isValid = m_isValid;
             data->m_ip = m_ip;
-            return nullptr;
+            return data;
         }
 
         const QHostAddress &QDnsRecordDataAAAA::getIp() const

src/modules/dns-base/src/RecordData/QDnsRecordDataMX.cpp

@@ -66,7 +66,7 @@ namespace QDns
             data->m_isValid = m_isValid;
             data->m_preference = m_preference;
             data->m_mx = m_mx;
-            return nullptr;
+            return data;
         }
 
         quint16 QDnsRecordDataMX::getPreference() const

src/modules/dns-base/tests/RecordData/DnsRDataA.cpp

@@ -25,15 +25,17 @@ TEST_P(DnsRDataATest, parseAndGetters)
 {
     auto params = GetParam();
     auto data = QByteArray::fromHex(params.hexData);
-    auto rdata = QDns::Base::QDnsRecordDataA(data, params.pos);
-    ASSERT_EQ(rdata.isValid(), params.isValid);
+    auto rdata = dynamic_cast<QDns::Base::QDnsRecordDataA*>(QDns::Base::QDnsRecordDataA(data, params.pos).clone());
+    ASSERT_NE(rdata, nullptr);
+    ASSERT_EQ(rdata->isValid(), params.isValid);
     
-    if (rdata.isValid())
+    if (rdata->isValid())
     {
-        ASSERT_EQ(rdata.getIp().toIPv4Address(), params.ip);
+        ASSERT_EQ(rdata->getIp().toIPv4Address(), params.ip);
         
-        ASSERT_EQ(rdata.serialize().toHex(), QString(params.hexData).remove(" "));
+        ASSERT_EQ(rdata->serialize().toHex(), QString(params.hexData).remove(" "));
     }
+    delete rdata;
 }
 
 INSTANTIATE_TEST_CASE_P(DnsRDataATestInst,

src/modules/dns-base/tests/RecordData/DnsRDataAAAA.cpp

@@ -25,18 +25,20 @@ TEST_P(DnsRDataAAAATest, parseAndGetters)
 {
     auto params = GetParam();
     auto data = QByteArray::fromHex(params.hexData);
-    auto rdata = QDns::Base::QDnsRecordDataAAAA(data, params.pos);
-    ASSERT_EQ(rdata.isValid(), params.isValid);
+    auto rdata = dynamic_cast<QDns::Base::QDnsRecordDataAAAA*>(QDns::Base::QDnsRecordDataAAAA(data, params.pos).clone());
+    ASSERT_NE(rdata, nullptr);
+    ASSERT_EQ(rdata->isValid(), params.isValid);
     
-    if (rdata.isValid())
+    if (rdata->isValid())
     {
         for (int i = 0; i < 16; ++i)
         {
-            ASSERT_EQ(rdata.getIp().toIPv6Address()[i], params.ip[i]);
+            ASSERT_EQ(rdata->getIp().toIPv6Address()[i], params.ip[i]);
         }
         
-        ASSERT_EQ(rdata.serialize().toHex(), QString(params.hexData).remove(" "));
+        ASSERT_EQ(rdata->serialize().toHex(), QString(params.hexData).remove(" "));
     }
+    delete rdata;
 }
 
 INSTANTIATE_TEST_CASE_P(DnsRDataAAAATestInst,

src/modules/dns-base/tests/RecordData/DnsRDataMX.cpp

@@ -26,16 +26,18 @@ TEST_P(DnsRDataMXTest, parseAndGetters)
 {
     auto params = GetParam();
     auto data = QByteArray::fromHex(params.hexData);
-    auto rdata = QDns::Base::QDnsRecordDataMX(data, params.pos);
-    ASSERT_EQ(rdata.isValid(), params.isValid);
+    auto rdata = dynamic_cast<QDns::Base::QDnsRecordDataMX*>(QDns::Base::QDnsRecordDataMX(data, params.pos).clone());
+    ASSERT_NE(rdata, nullptr);
+    ASSERT_EQ(rdata->isValid(), params.isValid);
     
-    if (rdata.isValid())
+    if (rdata->isValid())
     {
-        ASSERT_EQ(params.preference, rdata.getPreference());
-        ASSERT_EQ(params.mx, rdata.getMx());
+        ASSERT_EQ(params.preference, rdata->getPreference());
+        ASSERT_EQ(params.mx, rdata->getMx());
 
-        ASSERT_EQ(rdata.serialize().toHex(), QString(params.hexData).remove(" "));
+        ASSERT_EQ(rdata->serialize().toHex(), QString(params.hexData).remove(" "));
     }
+    delete rdata;
 }
 
 INSTANTIATE_TEST_CASE_P(DnsRDataMXTestInst,

src/modules/dns-base/tests/RecordData/DnsRDataPTR.cpp

@@ -25,15 +25,17 @@ TEST_P(DnsRDataPTRTest, parseAndGetters)
 {
     auto params = GetParam();
     auto data = QByteArray::fromHex(params.hexData);
-    auto rdata = QDns::Base::QDnsRecordDataPTR(data, params.pos);
-    ASSERT_EQ(rdata.isValid(), params.isValid);
+    auto rdata = dynamic_cast<QDns::Base::QDnsRecordDataPTR*>(QDns::Base::QDnsRecordDataPTR(data, params.pos).clone());
+    ASSERT_NE(rdata, nullptr);
+    ASSERT_EQ(rdata->isValid(), params.isValid);
 
-    if (rdata.isValid())
+    if (rdata->isValid())
     {
-        ASSERT_EQ(params.hostname, rdata.getHostname());
+        ASSERT_EQ(params.hostname, rdata->getHostname());
 
-        ASSERT_EQ(rdata.serialize().toHex(), QString(params.hexData).remove(" "));
+        ASSERT_EQ(rdata->serialize().toHex(), QString(params.hexData).remove(" "));
     }
+    delete rdata;
 }
 
 INSTANTIATE_TEST_CASE_P(DnsRDataPTRTestInst,

src/modules/dns-base/tests/RecordData/DnsRDataSOA.cpp

@@ -31,21 +31,23 @@ TEST_P(DnsRDataSOATest, parseAndGetters)
 {
     auto params = GetParam();
     auto data = QByteArray::fromHex(params.hexData);
-    auto rdata = QDns::Base::QDnsRecordDataSOA(data, params.pos);
-    ASSERT_EQ(rdata.isValid(), params.isValid);
+    auto rdata = dynamic_cast<QDns::Base::QDnsRecordDataSOA*>(QDns::Base::QDnsRecordDataSOA(data, params.pos).clone());
+    ASSERT_NE(rdata, nullptr);
+    ASSERT_EQ(rdata->isValid(), params.isValid);
 
-    if (rdata.isValid())
+    if (rdata->isValid())
     {
-        ASSERT_EQ(params.primaryNs, rdata.getPrimaryNs());
-        ASSERT_EQ(params.adminMb, rdata.getAdminMb());
-        ASSERT_EQ(params.serialNumber, rdata.getSerialNumber());
-        ASSERT_EQ(params.refreshInterval, rdata.getRefreshInterval());
-        ASSERT_EQ(params.retryInterval, rdata.getRetryInterval());
-        ASSERT_EQ(params.expirationLimit, rdata.getExpirationLimit());
-        ASSERT_EQ(params.minimumTtl, rdata.getMinimumTtl());
-
-        ASSERT_EQ(rdata.serialize().toHex(), QString(params.hexData).remove(" "));
+        ASSERT_EQ(params.primaryNs, rdata->getPrimaryNs());
+        ASSERT_EQ(params.adminMb, rdata->getAdminMb());
+        ASSERT_EQ(params.serialNumber, rdata->getSerialNumber());
+        ASSERT_EQ(params.refreshInterval, rdata->getRefreshInterval());
+        ASSERT_EQ(params.retryInterval, rdata->getRetryInterval());
+        ASSERT_EQ(params.expirationLimit, rdata->getExpirationLimit());
+        ASSERT_EQ(params.minimumTtl, rdata->getMinimumTtl());
+
+        ASSERT_EQ(rdata->serialize().toHex(), QString(params.hexData).remove(" "));
     }
+    delete rdata;
 }
 
 INSTANTIATE_TEST_CASE_P(DnsRDataSOATestInst,