Browse Source

Fixed QDnsHeader {set,is}Query methods and associated tests

develop
Robin Thoni 6 years ago
parent
commit
5d9224419b

+ 2
- 2
src/modules/dns-base/src/QDnsHeader.cpp View File

126
 
126
 
127
         bool QDnsHeader::isQuery() const
127
         bool QDnsHeader::isQuery() const
128
         {
128
         {
129
-            return (bool) getFlagBits(0, 1);
129
+            return !(bool) getFlagBits(0, 1);
130
         }
130
         }
131
 
131
 
132
         void QDnsHeader::setIsQuery(bool isQuery)
132
         void QDnsHeader::setIsQuery(bool isQuery)
133
         {
133
         {
134
-            setFlagBits(0, (quint8) isQuery, 1);
134
+            setFlagBits(0, (quint8) !isQuery, 1);
135
         }
135
         }
136
 
136
 
137
         quint8 QDnsHeader::getOpcode() const
137
         quint8 QDnsHeader::getOpcode() const

+ 4
- 4
src/modules/dns-base/tests/DnsHeader.cpp View File

166
                                                      0x3cdc,
166
                                                      0x3cdc,
167
 
167
 
168
                                                      0x0100,
168
                                                      0x0100,
169
-                                                     false,
169
+                                                     true,
170
                                                      0,
170
                                                      0,
171
                                                      false,
171
                                                      false,
172
                                                      false,
172
                                                      false,
186
                                                      "3c dc 81 80 00 01 00 01  00 00 00 00",
186
                                                      "3c dc 81 80 00 01 00 01  00 00 00 00",
187
                                                      0x3cdc,
187
                                                      0x3cdc,
188
                                                      0x8180,
188
                                                      0x8180,
189
-                                                     true,
189
+                                                     false,
190
                                                      0,
190
                                                      0,
191
                                                      false,
191
                                                      false,
192
                                                      false,
192
                                                      false,
207
                                                      "3c dc aa aa aa aa 55 55  55 ff ff 55",
207
                                                      "3c dc aa aa aa aa 55 55  55 ff ff 55",
208
                                                      0x3cdc,
208
                                                      0x3cdc,
209
                                                      0xaaaa,
209
                                                      0xaaaa,
210
-                                                     true,
210
+                                                     false,
211
                                                      5,
211
                                                      5,
212
                                                      false,
212
                                                      false,
213
                                                      true,
213
                                                      true,
227
                                                      "3c dc 55 55 55 ff aa aa  ff 55 55 55",
227
                                                      "3c dc 55 55 55 ff aa aa  ff 55 55 55",
228
                                                      0x3cdc,
228
                                                      0x3cdc,
229
                                                      0x5555,
229
                                                      0x5555,
230
-                                                     false,
230
+                                                     true,
231
                                                      10,
231
                                                      10,
232
                                                      true,
232
                                                      true,
233
                                                      false,
233
                                                      false,

Loading…
Cancel
Save