Browse Source

[script] Avoid trying to read final character of a zero-length string

Detected using Valgrind.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
tags/v1.20.1
Michael Brown 11 years ago
parent
commit
e52c24492a
1 changed files with 2 additions and 2 deletions
  1. 2
    2
      src/image/script.c

+ 2
- 2
src/image/script.c View File

92
 		script_offset += ( frag_len + 1 );
92
 		script_offset += ( frag_len + 1 );
93
 
93
 
94
 		/* Strip trailing CR, if present */
94
 		/* Strip trailing CR, if present */
95
-		if ( line[ len - 1 ] == '\r' )
95
+		if ( len && ( line[ len - 1 ] == '\r' ) )
96
 			len--;
96
 			len--;
97
 
97
 
98
 		/* Handle backslash continuations */
98
 		/* Handle backslash continuations */
99
-		if ( line[ len - 1 ] == '\\' ) {
99
+		if ( len && ( line[ len - 1 ] == '\\' ) ) {
100
 			len--;
100
 			len--;
101
 			rc = -EINVAL;
101
 			rc = -EINVAL;
102
 			continue;
102
 			continue;

Loading…
Cancel
Save