Browse Source

[smsc75xx] Move RX FIFO overflow message to DBGLVL_EXTRA

RX FIFO overflow is almost inevitable since the (usable) USB2 bus
bandwidth is approximately one quarter of the Ethernet bandwidth.
Avoid flooding the console with RX FIFO overflow messages in a
standard debug build.

With TCP SACK implemented, the RX FIFO overflow no longer causes a
catastrophic drop in throughput.  Experimentation shows that HTTP
downloads now progress at a fairly smooth 250Mbps, which is around the
maximum speed attainable for a USB2 NIC.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
tags/v1.20.1
Michael Brown 9 years ago
parent
commit
7f80eb511e
1 changed files with 2 additions and 1 deletions
  1. 2
    1
      src/drivers/net/smsc75xx.c

+ 2
- 1
src/drivers/net/smsc75xx.c View File

@@ -915,7 +915,8 @@ static void smsc75xx_poll ( struct net_device *netdev ) {
915 915
 
916 916
 	/* Record RX FIFO overflow if applicable */
917 917
 	if ( int_sts & SMSC75XX_INT_STS_RDFO_INT ) {
918
-		DBGC ( smsc75xx, "SMSC75XX %p RX FIFO overflowed\n", smsc75xx );
918
+		DBGC2 ( smsc75xx, "SMSC75XX %p RX FIFO overflowed\n",
919
+			smsc75xx );
919 920
 		netdev_rx_err ( netdev, NULL, -ENOBUFS );
920 921
 		int_sts &= ~SMSC75XX_INT_STS_RDFO_INT;
921 922
 	}

Loading…
Cancel
Save