Browse Source

[realtek] Use explicit value for TCR.MXDMA

Some RTL8169 cards (observed with an RTL8169SC) power up with
TCR.MXDMA set to 16 bytes.  While this does not prevent proper
operation, it almost certainly degrades performance.

Fix by explicitly setting TCR.MXDMA to "unlimited".

Signed-off-by: Michael Brown <mcb30@ipxe.org>
tags/v1.20.1
Michael Brown 11 years ago
parent
commit
77afdc5643
2 changed files with 13 additions and 0 deletions
  1. 7
    0
      src/drivers/net/realtek.c
  2. 6
    0
      src/drivers/net/realtek.h

+ 7
- 0
src/drivers/net/realtek.c View File

500
  */
500
  */
501
 static int realtek_open ( struct net_device *netdev ) {
501
 static int realtek_open ( struct net_device *netdev ) {
502
 	struct realtek_nic *rtl = netdev->priv;
502
 	struct realtek_nic *rtl = netdev->priv;
503
+	uint32_t tcr;
503
 	uint32_t rcr;
504
 	uint32_t rcr;
504
 	int rc;
505
 	int rc;
505
 
506
 
524
 	 */
525
 	 */
525
 	writeb ( ( RTL_CR_TE | RTL_CR_RE ), rtl->regs + RTL_CR );
526
 	writeb ( ( RTL_CR_TE | RTL_CR_RE ), rtl->regs + RTL_CR );
526
 
527
 
528
+	/* Configure transmitter */
529
+	tcr = readl ( rtl->regs + RTL_TCR );
530
+	tcr &= ~RTL_TCR_MXDMA_MASK;
531
+	tcr |= RTL_TCR_MXDMA_DEFAULT;
532
+	writel ( tcr, rtl->regs + RTL_TCR );
533
+
527
 	/* Configure receiver */
534
 	/* Configure receiver */
528
 	rcr = readl ( rtl->regs + RTL_RCR );
535
 	rcr = readl ( rtl->regs + RTL_RCR );
529
 	rcr &= ~( RTL_RCR_RXFTH_MASK | RTL_RCR_RBLEN_MASK |
536
 	rcr &= ~( RTL_RCR_RXFTH_MASK | RTL_RCR_RBLEN_MASK |

+ 6
- 0
src/drivers/net/realtek.h View File

132
 /** Interrupt Status Register (word) */
132
 /** Interrupt Status Register (word) */
133
 #define RTL_ISR 0x3e
133
 #define RTL_ISR 0x3e
134
 
134
 
135
+/** Transmit (Tx) Configuration Register (dword) */
136
+#define RTL_TCR 0x40
137
+#define RTL_TCR_MXDMA(x)	( (x) << 8 ) /**< Max DMA burst size */
138
+#define RTL_TCR_MXDMA_MASK	RTL_TCR_MXDMA ( 0x7 )
139
+#define RTL_TCR_MXDMA_DEFAULT	RTL_TCR_MXDMA ( 0x7 /* Unlimited */ )
140
+
135
 /** Receive (Rx) Configuration Register (dword) */
141
 /** Receive (Rx) Configuration Register (dword) */
136
 #define RTL_RCR 0x44
142
 #define RTL_RCR 0x44
137
 #define RTL_RCR_RXFTH(x)	( (x) << 13 ) /**< Receive FIFO threshold */
143
 #define RTL_RCR_RXFTH(x)	( (x) << 13 ) /**< Receive FIFO threshold */

Loading…
Cancel
Save