Browse Source

[iscsi] Add missing "break" statements

iscsi_tx_done() is missing "break" statements at the end of each case.
(Fortunately, this happens not to cause a bug in practice, since
iscsi_login_request_done() is effectively a no-op when completing a
data-out PDU.)

Reported-by: Wissam Shoukair <wissams@mellanox.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
tags/v1.20.1
Michael Brown 9 years ago
parent
commit
76338543f9
1 changed files with 2 additions and 0 deletions
  1. 2
    0
      src/net/tcp/iscsi.c

+ 2
- 0
src/net/tcp/iscsi.c View File

1439
 	switch ( common->opcode & ISCSI_OPCODE_MASK ) {
1439
 	switch ( common->opcode & ISCSI_OPCODE_MASK ) {
1440
 	case ISCSI_OPCODE_DATA_OUT:
1440
 	case ISCSI_OPCODE_DATA_OUT:
1441
 		iscsi_data_out_done ( iscsi );
1441
 		iscsi_data_out_done ( iscsi );
1442
+		break;
1442
 	case ISCSI_OPCODE_LOGIN_REQUEST:
1443
 	case ISCSI_OPCODE_LOGIN_REQUEST:
1443
 		iscsi_login_request_done ( iscsi );
1444
 		iscsi_login_request_done ( iscsi );
1445
+		break;
1444
 	default:
1446
 	default:
1445
 		/* No action */
1447
 		/* No action */
1446
 		break;
1448
 		break;

Loading…
Cancel
Save