Browse Source

[realtek] Allow reaction time between writing RTL_CAPR and reading RTL_CR

Some older RTL8139 chips seem to not immediately update the
RTL_CR.BUFE bit in response to a write to RTL_CAPR.  This results in
iPXE seeing a spurious zero-length received packet, and thereafter
being out of sync with the hardware's RX ring offset.

Fix by inserting an extra PCI read cycle after writing to RTL_CAPR, to
give the chip time to react before we next read RTL_CR.

Reported-by: Gelip <mrgelip@gmail.com>
Tested-by: Gelip <mrgelip@gmail.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
tags/v1.20.1
Michael Brown 11 years ago
parent
commit
592755eccf
1 changed files with 3 additions and 0 deletions
  1. 3
    0
      src/drivers/net/realtek.c

+ 3
- 0
src/drivers/net/realtek.c View File

861
 		rtl->rx_offset = ( ( rtl->rx_offset + 3 ) & ~3 );
861
 		rtl->rx_offset = ( ( rtl->rx_offset + 3 ) & ~3 );
862
 		rtl->rx_offset = ( rtl->rx_offset % RTL_RXBUF_LEN );
862
 		rtl->rx_offset = ( rtl->rx_offset % RTL_RXBUF_LEN );
863
 		writew ( ( rtl->rx_offset - 16 ), rtl->regs + RTL_CAPR );
863
 		writew ( ( rtl->rx_offset - 16 ), rtl->regs + RTL_CAPR );
864
+
865
+		/* Give chip time to react before rechecking RTL_CR */
866
+		readw ( rtl->regs + RTL_CAPR );
864
 	}
867
 	}
865
 }
868
 }
866
 
869
 

Loading…
Cancel
Save