Browse Source

[spi] Reset device on each access

When chainloading rtl8139.pxe from an old Etherboot rtl8139.zrom, iPXE
can end up misreading the first word of the MAC address from the
EEPROM as being all zeroes.  This is presumably because Etherboot has
left the serial EEPROM in an unexpected state.

Fix by using the chip select line to reset the SPI device before we
start accessing it.

Reported-by: Mandar U Jog <mandarjog@gmail.com>
Tested-by: Mandar U Jog <mandarjog@gmail.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
tags/v1.20.1
Michael Brown 13 years ago
parent
commit
530a01eff0
1 changed files with 3 additions and 0 deletions
  1. 3
    0
      src/drivers/bitbash/spi_bit.c

+ 3
- 0
src/drivers/bitbash/spi_bit.c View File

@@ -162,6 +162,9 @@ static int spi_bit_rw ( struct spi_bus *bus, struct spi_device *device,
162 162
 	uint32_t tmp_address;
163 163
 	uint32_t tmp_address_detect;
164 164
 
165
+	/* Deassert chip select to reset specified slave */
166
+	spi_bit_set_slave_select ( spibit, device->slave, DESELECT_SLAVE );
167
+
165 168
 	/* Set clock line to idle state */
166 169
 	write_bit ( &spibit->basher, SPI_BIT_SCLK, 
167 170
 		    ( bus->mode & SPI_MODE_CPOL ) );

Loading…
Cancel
Save