Browse Source

[phantom] Do not halt PEGs on driver shutdown

Halting the PEGs breaks platforms where there is sideband access to
the NIC (e.g. HP machines using iLO).  (We have to retain the
unhalting code because on some other platforms (e.g. IBM blades with
BOFM) the pre-PXE firmware must halt the PEGs to avoid issues with the
BIOS rereading via the expansion ROM BAR.)
tags/v0.9.6
Michael Brown 16 years ago
parent
commit
46f43d8ea7
1 changed files with 0 additions and 15 deletions
  1. 0
    15
      src/drivers/net/phantom/phantom.c

+ 0
- 15
src/drivers/net/phantom/phantom.c View File

1784
 	return 0;
1784
 	return 0;
1785
 }
1785
 }
1786
 
1786
 
1787
-/**
1788
- * Halt all PEGs
1789
- *
1790
- * @v phantom		Phantom NIC
1791
- */
1792
-static void phantom_halt_pegs ( struct phantom_nic *phantom ) {
1793
-	phantom_writel ( phantom, 1, UNM_PEG_0_HALT );
1794
-	phantom_writel ( phantom, 1, UNM_PEG_1_HALT );
1795
-	phantom_writel ( phantom, 1, UNM_PEG_2_HALT );
1796
-	phantom_writel ( phantom, 1, UNM_PEG_3_HALT );
1797
-	phantom_writel ( phantom, 1, UNM_PEG_4_HALT );
1798
-}
1799
-
1800
 /**
1787
 /**
1801
  * Unhalt all PEGs
1788
  * Unhalt all PEGs
1802
  *
1789
  *
2089
  err_check_boot_enable:
2076
  err_check_boot_enable:
2090
  err_init_rcvpeg:
2077
  err_init_rcvpeg:
2091
  err_init_cmdpeg:
2078
  err_init_cmdpeg:
2092
-	phantom_halt_pegs ( phantom );
2093
  err_map_crb:
2079
  err_map_crb:
2094
 	netdev_nullify ( netdev );
2080
 	netdev_nullify ( netdev );
2095
 	netdev_put ( netdev );
2081
 	netdev_put ( netdev );
2108
 
2094
 
2109
 	unregister_settings ( &phantom->settings );
2095
 	unregister_settings ( &phantom->settings );
2110
 	unregister_netdev ( netdev );
2096
 	unregister_netdev ( netdev );
2111
-	phantom_halt_pegs ( phantom );
2112
 	netdev_nullify ( netdev );
2097
 	netdev_nullify ( netdev );
2113
 	netdev_put ( netdev );
2098
 	netdev_put ( netdev );
2114
 }
2099
 }

Loading…
Cancel
Save