[IPv4] Tidy up some header files.

src/include/gpxe/icmp6.h

@@ -7,7 +7,6 @@
  *
  */
 
-#include <ip.h>
 #include <gpxe/ip6.h>
 #include <gpxe/ndp.h>
 

src/include/gpxe/ip.h

@@ -7,9 +7,15 @@
  *
  */
 
-#include <ip.h>
+#include <stdint.h>
+#include <gpxe/in.h>
+#include <gpxe/list.h>
 #include <gpxe/retry.h>
 
+struct io_buffer;
+struct net_device;
+struct net_protocol;
+
 /* IP constants */
 
 #define IP_VER			0x40U
@@ -27,7 +33,21 @@
 #define IP_FRAG_IOB_SIZE	1500
 #define IP_FRAG_TIMEOUT		50
 
-/* IP4 pseudo header */
+/** An IPv4 packet header */
+struct iphdr {
+	uint8_t  verhdrlen;
+	uint8_t  service;
+	uint16_t len;
+	uint16_t ident;
+	uint16_t frags;
+	uint8_t  ttl;
+	uint8_t  protocol;
+	uint16_t chksum;
+	struct in_addr src;
+	struct in_addr dest;
+} __attribute__ (( packed ));
+
+/** An IPv4 pseudo header */
 struct ipv4_pseudo_header {
 	struct in_addr src;
 	struct in_addr dest;
@@ -68,11 +88,6 @@ struct frag_buffer {
 	struct list_head list;
 };
 
-struct io_buffer;
-struct net_device;
-struct net_protocol;
-struct tcpip_protocol;
-
 extern struct list_head ipv4_miniroutes;
 
 extern struct net_protocol ipv4_protocol;

src/include/gpxe/ip6.h

@@ -7,7 +7,7 @@
  *
  */
 
-#include <ip.h>
+#include <stdint.h>
 #include <gpxe/in.h>
 
 /* IP6 constants */

src/include/ip.h

@@ -1,23 +0,0 @@
-#ifndef	_IP_H
-#define	_IP_H
-
-#include "stddef.h"
-#include "stdint.h"
-#include <gpxe/in.h>
-
-struct iphdr {
-	uint8_t  verhdrlen;
-	uint8_t  service;
-	uint16_t len;
-	uint16_t ident;
-	uint16_t frags;
-	uint8_t  ttl;
-	uint8_t  protocol;
-	uint16_t chksum;
-	struct in_addr src;
-	struct in_addr dest;
-} PACKED;
-
-extern uint16_t tcpudpchksum(struct iphdr *ip);
-
-#endif	/* _IP_H */

src/include/udp.h

@@ -1,29 +0,0 @@
-#ifndef	_UDP_H
-#define	_UDP_H
-
-#include "stddef.h"
-#include "stdint.h"
-#include <gpxe/in.h>
-#include "ip.h"
-
-struct udp_pseudo_hdr {
-	struct in_addr  src;
-	struct in_addr  dest;
-	uint8_t  unused;
-	uint8_t  protocol;
-	uint16_t len;
-} PACKED;
-struct udphdr {
-	uint16_t src;
-	uint16_t dest;
-	uint16_t len;
-	uint16_t chksum;
-	struct {} payload;
-} PACKED;
-struct udppacket {
-	struct iphdr	ip;
-	struct udphdr	udp;
-	struct {} payload;
-} PACKED;
-
-#endif	/* _UDP_H */

src/proto/igmp.c

@@ -3,11 +3,11 @@
  *
  */
 
+#if 0
+
 #include <ip.h>
 #include <igmp.h>
 
-#if 0
-
 static unsigned long last_igmpv1 = 0;
 static struct igmptable_t igmptable[MAX_IGMP];