Parcourir la source

[libc] Ensure that error numbers from EUNIQ() have the correct type

Error numbers are signed ints.  EUNIQ() should not allow implicit type
promotion based on the supplied error diambiguator, because this
causes problems with statements such as

  rc = ( condition ? -EUNIQ ( EBASE, disambiguator ) : -EBASE );

Signed-off-by: Michael Brown <mcb30@ipxe.org>
tags/v1.20.1
Michael Brown il y a 14 ans
Parent
révision
2a92697bda
1 fichiers modifiés avec 1 ajouts et 1 suppressions
  1. 1
    1
      src/include/errno.h

+ 1
- 1
src/include/errno.h Voir le fichier

@@ -201,7 +201,7 @@ extern char missing_errfile_declaration[] __attribute__ (( deprecated ));
201 201
  */
202 202
 #define EUNIQ( errno, uniq, ... ) ( {					\
203 203
 	euniq_discard ( 0, ##__VA_ARGS__);				\
204
-	( (errno) | ( (uniq) << 8 ) ); } )
204
+	( ( int ) ( (errno) | ( (uniq) << 8 ) ) ); } )
205 205
 static inline void euniq_discard ( int dummy __unused, ... ) {}
206 206
 
207 207
 /**

Chargement…
Annuler
Enregistrer