Browse Source

[eoib] Avoid passing a NULL I/O buffer to netdev_tx_complete_err()

Report errors in eoib_duplicate() via netdev_tx_err() rather than
netdev_tx_complete_err(), since netdev_tx_complete_err() accepts only
valid I/O buffers that are currently in the network device's transmit
queue.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
tags/v1.20.1
Michael Brown 7 years ago
parent
commit
1ec2a60614
1 changed files with 2 additions and 1 deletions
  1. 2
    1
      src/drivers/net/eoib.c

+ 2
- 1
src/drivers/net/eoib.c View File

@@ -870,8 +870,9 @@ static void eoib_duplicate ( struct eoib_device *eoib,
870 870
 
871 871
  err_post_send:
872 872
  err_path:
873
+	list_del ( &copy->list );
873 874
  err_alloc:
874
-	netdev_tx_complete_err ( netdev, copy, rc );
875
+	netdev_tx_err ( netdev, copy, rc );
875 876
 }
876 877
 
877 878
 /**

Loading…
Cancel
Save