Parcourir la source

[block] Add a small delay between attempts to reopen SAN targets

When all SAN targets are completely unreachable, there will be a
natural delay between reopening attempts due to the network connection
timeout on the unreachable targets.

However, some SAN targets may accept connections instantly and report
a temporary unavailability by e.g. failing the TEST UNIT READY
command.  If all targets are behaving this way then there will be no
natural delay, and we will attempt to saturate the network with
connection attempts.

Fix by introducing a small delay between attempts.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
tags/v1.20.1
Michael Brown il y a 7 ans
Parent
révision
164378fee6
1 fichiers modifiés avec 14 ajouts et 0 suppressions
  1. 14
    0
      src/core/sanboot.c

+ 14
- 0
src/core/sanboot.c Voir le fichier

@@ -74,6 +74,16 @@ FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
74 74
  */
75 75
 #define SAN_DEFAULT_RETRIES 10
76 76
 
77
+/**
78
+ * Delay between reopening attempts
79
+ *
80
+ * Some SAN targets will always accept connections instantly and
81
+ * report a temporary unavailability by e.g. failing the TEST UNIT
82
+ * READY command.  Avoid bombarding such targets by introducing a
83
+ * small delay between attempts.
84
+ */
85
+#define SAN_REOPEN_DELAY_SECS 5
86
+
77 87
 /** List of SAN devices */
78 88
 LIST_HEAD ( san_devices );
79 89
 
@@ -484,6 +494,10 @@ sandev_command ( struct san_device *sandev,
484 494
 		/* Reopen block device if applicable */
485 495
 		if ( sandev_needs_reopen ( sandev ) &&
486 496
 		     ( ( rc = sandev_reopen ( sandev ) ) != 0 ) ) {
497
+
498
+			/* Delay reopening attempts */
499
+			sleep_fixed ( SAN_REOPEN_DELAY_SECS );
500
+
487 501
 			continue;
488 502
 		}
489 503
 

Chargement…
Annuler
Enregistrer