removed users not in group

src/Auth/Business/LuticateBusiness.php

@@ -83,8 +83,6 @@ class LuticateBusiness
 
         $route->get("$prefix/groups/$group_id/users/", "${ns}LuticateGroupsController", "getUsers",
             LuticatePermissions::GROUP_GET);
-        $route->get("$prefix/groups/$group_id/others/", "${ns}LuticateGroupsController", "getOtherUsers",
-            LuticatePermissions::GROUP_GET);
         $route->post("$prefix/groups/$group_id/users/$user_id/add", "${ns}LuticateGroupsController", "addUser",
             array(LuticatePermissions::GROUP_USER_ADD, LuticatePermissions::GROUP_GET));
         $route->post("$prefix/groups/$group_id/users/$user_id/del", "${ns}LuticateGroupsController", "delUser",

src/Auth/Business/LuticateGroupsBusiness.php

@@ -30,11 +30,6 @@ class LuticateGroupsBusiness extends LuBusiness {
         return LuticateGroupsDataAccess::getUsers($group_id, $page, $perPage, $query);
     }
 
-    public static function getOtherUsers($group_id, $page = 0, $perPage = PHP_INT_MAX, $query = "")
-    {
-        return LuticateGroupsDataAccess::getOtherUsers($group_id, $page, $perPage, $query);
-    }
-
     public static function getByName($group_name)
     {
         return LuticateGroupsDataAccess::getByName($group_name);

src/Auth/Controller/LuticateGroupsController.php

@@ -47,19 +47,6 @@ class LuticateGroupsController extends LuController {
         return LuticateGroupsBusiness::getUsers($group_id, $page, $perPage, $query);
     }
 
-    /**
-     * Get all users not in group
-     * @param $group_id int The group id
-     * @param int $page The page number, 0 based
-     * @param int $perPage The number of items per page
-     * @param string $query The filter query
-     * @return \Luticate\Utils\LuMultipleDbo
-     */
-    public function getOtherUsers($group_id, $page = 0, $perPage = PHP_INT_MAX, $query = "")
-    {
-        return LuticateGroupsBusiness::getOtherUsers($group_id, $page, $perPage, $query);
-    }
-
     /**
      * Add a new group
      * @param $group_name string The group name

src/Auth/DataAccess/LuticateGroupsDataAccess.php

@@ -59,28 +59,6 @@ class LuticateGroupsDataAccess extends LuDataAccess {
         return new LuMultipleDbo($count, $usersLight);
     }
 
-    public static function getOtherUsers($group_id, $page = 0, $perPage = PHP_INT_MAX, $query = "")
-    {
-        $model = LuticateUsers::where("luticate_users_groups.id", "IS", "NULL")
-            ->leftJoin("luticate_users_groups", function($join) use ($group_id)
-            {
-                $join->on("luticate_users.id", "=", "luticate_users_groups.user_id")
-                ->on("luticate_users_groups.group_id", "=", $group_id);
-            });
-
-        $count = $model->count();
-
-        $model = $model->orderBy("luticate_users.username", "ASC");
-        $data = $model->take($perPage)->offset($page * $perPage)->get();
-        $usersLight = [];
-        foreach ($data as $user) {
-            if (!is_null($user)) {
-                $usersLight[] = LuticateUsersLightDbo::fromUserDbo($user->toDbo());
-            }
-        }
-        return new LuMultipleDbo($count, $usersLight);
-    }
-
     public static function addUser($user_id, $group_id)
     {
         LuticateGroups::find($group_id)->users()->attach($user_id);