improved camera

app/Http/Business/Cameras/AbstractCamera.php

@@ -8,9 +8,10 @@
 
 namespace app\Http\Business\Cameras;
 
-
 use App\Http\DBO\CamerasDbo;
-use app\Http\DBO\CamerasImageDbo;
+use App\Http\DBO\CamerasImageDbo;
+use Imagine\Imagick\Image;
+use Imagine\Imagick\Imagine;
 
 abstract class AbstractCamera
 {
@@ -18,14 +19,31 @@ abstract class AbstractCamera
      * @var CamerasDbo
      */
     protected $_camera;
+    /**
+     * @var $_imagine Imagine
+     */
+    protected $_imagine;
+    /**
+     * @var $_image Image
+     */
+    protected $_image;
 
     public function __construct(CamerasDbo $camera)
     {
         $this->_camera = $camera;
+        $this->_imagine = new Imagine();
     }
 
     /**
      * @return CamerasImageDbo
      */
-    public abstract function getImage();
+    public function getImage()
+    {
+        $this->prepareImage();
+        $imageDbo = new CamerasImageDbo();
+        $imageDbo->setImage(base64_encode($this->_image->get("jpeg")));
+        return $imageDbo;
+    }
+
+    public abstract function prepareImage();
 }

app/Http/Business/Cameras/DummyCamera.php

@@ -8,44 +8,25 @@
 
 namespace App\Http\Business\Cameras;
 
-
 use App\Http\DBO\CamerasDbo;
-use App\Http\DBO\CamerasImageDbo;
 use Imagine\Image\Box;
 use Imagine\Image\Palette\RGB;
 use Imagine\Image\Point;
-use Imagine\Imagick\Image;
-use Imagine\Imagick\Imagine;
 
 class DummyCamera extends AbstractCamera
 {
-    /**
-     * @var $_image Image
-     */
-    private $_image;
-    /**
-     * @var $_imagine Imagine
-     */
-    private $_imagine;
 
     public function __construct(CamerasDbo $camera)
     {
         parent::__construct($camera);
-        $this->_imagine = new Imagine();
         $this->_image = $this->_imagine->open("../resources/images/dummy_camera.jpg");
     }
 
-    /**
-     * @return CamerasImageDbo
-     */
-    public function getImage()
+    public function prepareImage()
     {
-        $imageDbo = new CamerasImageDbo();
         $draw = $this->_image->draw();
         $palette = new RGB();
         $radius = rand(10, 42);
         $draw->ellipse(new Point(42, 42), new Box($radius, $radius), $palette->color('#ff0000'));
-        $imageDbo->setImage(base64_encode($this->_image->get("jpeg")));
-        return $imageDbo;
     }
 }